feat: support CODER_AGENT_TOKEN from Kubernetes secrets #144
+496
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacpersaw
force-pushed
the
kacpersaw/agent-token-k8s-secret
branch
2 times, most recently
from
802b1e2 to
8f6d20d
Compare
Member
deansheather
left a comment
deansheather
left a comment
There was a problem hiding this comment.
The necessary RBAC changes should be updated in the helm templates
This change adds support for reading CODER_AGENT_TOKEN from Kubernetes secrets via secretKeyRef, in addition to the existing inline value support. Changes: - Add resolveEnvValue helper function that resolves env var values from either direct values or secretKeyRef references - Update Pod handler to use resolveEnvValue for token resolution - Update ReplicaSet handler to use resolveEnvValue for token resolution - Add comprehensive tests for secretKeyRef functionality The implementation is fully backward compatible: - Existing inline env.Value tokens continue to work unchanged - secretKeyRef support is additive, not a breaking change - Optional secrets that don't exist are handled gracefully - Errors fetching required secrets log warnings and skip the pod Users who want to use secretKeyRef will need to ensure their service account has RBAC permissions to get secrets in the watched namespaces. Fixes #139
Required to support reading CODER_AGENT_TOKEN from Kubernetes secrets via secretKeyRef.
Add integration tests that verify CODER_AGENT_TOKEN can be read from Kubernetes secrets via secretKeyRef for both Pods and ReplicaSets.
kacpersaw
force-pushed
the
kacpersaw/agent-token-k8s-secret
branch
from
0013ad7 to
abe9899
Compare
deansheather
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for reading
CODER_AGENT_TOKENfrom Kubernetes secrets viasecretKeyRef, in addition to the existing inline value support.Fixes #139
Changes
resolveEnvValuehelper function that resolves env var values from either direct values orsecretKeyRefreferencesresolveEnvValuefor token resolutionresolveEnvValuefor token resolutionsecretKeyReffunctionalityBackward Compatibility
This change is fully backward compatible:
env.Valueset directlyenv.ValueFrom.SecretKeyRefenv.Valuetokens continue to work unchangedsecretKeyRefsupport is additive, not a breaking changeRBAC Requirements
Users who want to use
secretKeyRefwill need to ensure their service account has RBAC permissions to get secrets in the watched namespaces:Testing
TestPodEventsWithSecretRef- verifies pods with secretKeyRef work correctlyTestReplicaSetEventsWithSecretRef- verifies ReplicaSets with secretKeyRef work correctlyTestPodEventsWithOptionalMissingSecret- verifies optional missing secrets are handled gracefully